Python: Function calling in Google connectors #7603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaoChenOSU
added
PR: in progress
github-actions
bot
changed the title
TaoChenOSU
removed
the
PR: in progress
moonbox3
reviewed
Aug 2, 2024
python/semantic_kernel/connectors/ai/google/google_ai/services/google_ai_chat_completion.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/ai/google/google_ai/services/google_ai_chat_completion.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/ai/google/vertex_ai/services/vertex_ai_chat_completion.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/ai/google/vertex_ai/vertex_ai_prompt_execution_settings.py
Outdated
Show resolved
Hide resolved
moonbox3
approved these changes
Aug 2, 2024
juliomenendez
approved these changes
Aug 2, 2024
moonbox3
approved these changes
Aug 2, 2024
alliscode
approved these changes
Aug 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ermattson
approved these changes
Aug 2, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Function calling is a fundamental feature in AI connectors and most Gemini models support function calling. We've just added two Google connectors: Google AI & Vertex AI to SK. This PR adds function calling to those two connectors. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Add function calling to Google AI & Vertex AI connectors. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Function calling is a fundamental feature in AI connectors and most Gemini models support function calling. We've just added two Google connectors: Google AI & Vertex AI to SK. This PR adds function calling to those two connectors.
Description
Add function calling to Google AI & Vertex AI connectors.
Contribution Checklist